New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New RemoteLoader #539

Merged

cecinestpasunepipe merged 32 commits into main from DIS-2907_Targetd2

Mar 12, 2024

Contributor

cecinestpasunepipe commented Feb 14, 2024

(DIS-2907)

cecinestpasunepipe force-pushed the DIS-2907_Targetd2 branch from 462562c to 31c2c87 Compare

February 14, 2024 14:46

cecinestpasunepipe closed this

cecinestpasunepipe force-pushed the DIS-2907_Targetd2 branch from 31c2c87 to 6d3e728 Compare

February 14, 2024 16:32

Schamper temporarily deployed to dissect_publish

February 14, 2024 16:32

— with

GitHub Actions Inactive

cecinestpasunepipe reopened this

cecinestpasunepipe marked this pull request as ready for review

February 19, 2024 17:46

cecinestpasunepipe requested a review from Miauwkeru

February 21, 2024 09:38

codecov bot commented Feb 21, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 90.79498% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 74.24%. Comparing base (4998ca3) to head (b51ef3a).

Files	Patch %	Lines
dissect/target/loaders/mqtt.py	90.65%	20 Missing ⚠️
dissect/target/plugins/child/mqtt.py	90.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   74.03%   74.24%   +0.20%     
==========================================
  Files         285      287       +2     
  Lines       23592    23830     +238     
==========================================
+ Hits        17466    17692     +226     
- Misses       6126     6138      +12

Flag	Coverage Δ
unittests	`74.24% <90.79%> (+0.20%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Miauwkeru requested changes

View reviewed changes

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

pyproject.toml Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/plugins/child/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

tests/loaders/test_mqtt.py Outdated Show resolved Hide resolved

cecinestpasunepipe requested a review from Miauwkeru

February 26, 2024 17:48

Miauwkeru requested changes

View reviewed changes

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Show resolved Hide resolved

cecinestpasunepipe force-pushed the DIS-2907_Targetd2 branch from a2b88d1 to 0334aa1 Compare

February 27, 2024 14:27

cecinestpasunepipe requested a review from Miauwkeru

February 27, 2024 14:31

cecinestpasunepipe force-pushed the DIS-2907_Targetd2 branch 2 times, most recently from 690d11c to 5e8b07c Compare

March 4, 2024 08:33

cecinestpasunepipe force-pushed the DIS-2907_Targetd2 branch from 5e8b07c to b51ef3a Compare

March 6, 2024 15:56

Miauwkeru requested changes

View reviewed changes

Contributor

Miauwkeru left a comment

Only a few empty lines to improve readability

dissect/target/loaders/mqtt.py Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Show resolved Hide resolved

dissect/target/loaders/mqtt.py Show resolved Hide resolved

dissect/target/loaders/mqtt.py Show resolved Hide resolved

dissect/target/loaders/mqtt.py Outdated Show resolved Hide resolved

dissect/target/loaders/mqtt.py Show resolved Hide resolved

cecinestpasunepipe force-pushed the DIS-2907_Targetd2 branch from b51ef3a to 92a215e Compare

March 11, 2024 14:15

codecov-commenter commented Mar 11, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 90.79498% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 74.69%. Comparing base (85b3f44) to head (58236fb).

Files	Patch %	Lines
dissect/target/loaders/mqtt.py	90.65%	20 Missing ⚠️
dissect/target/plugins/child/mqtt.py	90.47%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   74.51%   74.69%   +0.17%     
==========================================
  Files         286      288       +2     
  Lines       23653    23891     +238     
==========================================
+ Hits        17626    17845     +219     
- Misses       6027     6046      +19

Flag	Coverage Δ
unittests	`74.69% <90.79%> (+0.17%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cecinestpasunepipe requested a review from Miauwkeru

March 11, 2024 14:41

cecinestpasunepipe and others added 10 commits

March 12, 2024 09:33

WIP

ad6922e


          Add tests.

327b235


          Add types.

0e3a56d


          Add types.

0f7e119


          Update lru_cache.

d552fb7


          Add dependency MQTT-PAHO.

c8e9817


          Use posix_path for virtual path to child target.

a1c7dce


          Keep remoteloader, add separate mqttloader.


          Update dissect/target/loaders/mqtt.py

f57d566

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

e641e29

Co-authored-by: Miauwkeru <[email protected]>

cecinestpasunepipe and others added 22 commits

March 12, 2024 09:33


          Improvements

970ce85


          Update dissect/target/loaders/mqtt.py

b97ce48

Co-authored-by: Miauwkeru <[email protected]>


          Improvements

f7dadb6


          Update dissect/target/loaders/mqtt.py

23cf397

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

8d091c3

Co-authored-by: Miauwkeru <[email protected]>


          Update tests/loaders/test_mqtt.py

Co-authored-by: Miauwkeru <[email protected]>


          Improvements


          Improvements.

7af6f7d


          Improvements.

821b6c5


          Improvements.

6f3d41d


          Update dissect/target/loaders/mqtt.py

14a7952

Co-authored-by: Miauwkeru <[email protected]>


          Improvements.

97bd11c


          Improvements.

01b495b


          Update dissect/target/loaders/mqtt.py

1c30f51

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

9ca3b2a

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

dcba976

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

870d759

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

efaf054

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

f6ec4ec

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

35ccc3e

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

a634a53

Co-authored-by: Miauwkeru <[email protected]>


          Update dissect/target/loaders/mqtt.py

58236fb

Co-authored-by: Miauwkeru <[email protected]>

cecinestpasunepipe force-pushed the DIS-2907_Targetd2 branch from 704806d to 58236fb Compare

March 12, 2024 08:33

Miauwkeru approved these changes

View reviewed changes

cecinestpasunepipe merged commit 5c61adf into main

15 of 16 checks passed

cecinestpasunepipe deleted the DIS-2907_Targetd2 branch

March 12, 2024 08:52

Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request


          New RemoteLoader (fox-it#539)

c651672

(DIS-2907)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet