Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in defender evtx that resulted in ts field value being None #543

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Feb 19, 2024

(DIS-2561)

@Poeloe Poeloe requested review from Schamper and Miauwkeru February 19, 2024 10:37
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7fedd9) 73.94% compared to head (f3072d7) 73.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #543   +/-   ##
=======================================
  Coverage   73.94%   73.94%           
=======================================
  Files         284      284           
  Lines       23481    23481           
=======================================
  Hits        17363    17363           
  Misses       6118     6118           
Flag Coverage Δ
unittests 73.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a regression test?

@Poeloe Poeloe merged commit c7f8c0f into main Feb 19, 2024
16 checks passed
@Poeloe Poeloe deleted the fix/fix-bug-that-results-in-ts-is-none-for-defender-evtx branch February 19, 2024 12:59
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants