Fix bug in WER plugin caused by special characters in field name #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
- Coverage 73.98% 73.96% -0.02%
==========================================
Files 284 284
Lines 23521 23538 +17
==========================================
+ Hits 17401 17409 +8
- Misses 6120 6129 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Poeloe
force-pushed
the
fix/fix-bug-in-wer-plugin-caused-by-special-characters-in-field-name
branch
from
b3c4225 to
2f51dae
Compare
Schamper
reviewed
Feb 19, 2024
…characters-in-field-name
cecinestpasunepipe
suggested changes
Feb 19, 2024
| for pattern in camel_case_patterns: | ||
| key = pattern.sub(r"\1_\2", key) | ||
|
|
||
| # Keep only basic characters in key | ||
| key = re.sub(r"[^a-zA-Z0-9_]", "", key) |
There was a problem hiding this comment.
I foresee two possibly unwanted results:
- The key becomes empty ("невидимый")
- Or you might end up with duplicate keys (áErreur, éErreur)*
- 'lowercasing' might also cause this
If that is no problem, then it does not matter of course.
There was a problem hiding this comment.
True! Changed the code a bit around to be able to warn the user when these edge cases happen. I chose for a warning, because I don't think it's worth it to fully handle these edge cases. But please let me know if you think differently about this.
cecinestpasunepipe
approved these changes
Feb 20, 2024
…characters-in-field-name
…characters-in-field-name
Poeloe
deleted the
fix/fix-bug-in-wer-plugin-caused-by-special-characters-in-field-name
branch
Poeloe
added a commit
that referenced
this pull request
Feb 29, 2024
Zawadidone
pushed a commit
to Zawadidone/dissect.target
that referenced
this pull request
Apr 5, 2024
This was referenced Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-2507)