Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply bug workaround in plocate plugin to all PyPy versions #546

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

Horofic
Copy link
Contributor

@Horofic Horofic commented Feb 19, 2024

Apply the workaround to the whole of PyPy instead of just PyPy 3.9. Since it seems to affect PyPy 3.10 as well.

@Horofic Horofic requested a review from Schamper February 19, 2024 14:26
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c7f8c0f) 73.94% compared to head (567b592) 73.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   73.94%   73.94%   -0.01%     
==========================================
  Files         284      284              
  Lines       23481    23480       -1     
==========================================
- Hits        17363    17362       -1     
  Misses       6118     6118              
Flag Coverage Δ
unittests 73.94% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper changed the title Plocate pypy workaround Apply bug workaround in plocate plugin to all PyPy versions Feb 19, 2024
@Horofic Horofic merged commit 73cabc9 into main Feb 19, 2024
18 checks passed
@Horofic Horofic deleted the plocate-pypy310-workaround branch February 19, 2024 14:49
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants