Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve target registry tool #561

Merged
merged 8 commits into from
Mar 6, 2024
Merged

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Mar 4, 2024

This PR aims to improve the target-reg tool and adds tests.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.28%. Comparing base (4998ca3) to head (2b02c75).

Files Patch % Lines
dissect/target/tools/reg.py 86.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
+ Coverage   74.03%   74.28%   +0.25%     
==========================================
  Files         285      285              
  Lines       23592    23605      +13     
==========================================
+ Hits        17466    17535      +69     
+ Misses       6126     6070      -56     
Flag Coverage Δ
unittests 74.28% <86.66%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit d98a557 into fox-it:main Mar 6, 2024
18 checks passed
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
@JSCU-CNI JSCU-CNI deleted the improvement/target-reg branch August 1, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants