-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all test files to git LFS #562
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 74.28% 74.24% -0.04%
==========================================
Files 285 285
Lines 23605 23605
==========================================
- Hits 17535 17526 -9
- Misses 6070 6079 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hm this does remove the ability to preview a (text based) test file in a PR, which is also very annoying. |
That's an unfortunate side effect. Putting |
Yes, agreed. |
01402e1
to
51f46b5
Compare
51f46b5
to
eca9a0f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage 74.90% 74.90%
=======================================
Files 288 288
Lines 24115 24115
=======================================
Hits 18064 18064
Misses 6051 6051
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The decision on when to include a file in LFS was getting a bit annoying, and sometimes we forget. Just put it all in LFS.
We should update either the README or the docs at some point to include a small explanation on LFS too.