Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all test files to git LFS #562

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Add all test files to git LFS #562

merged 2 commits into from
Apr 10, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Mar 5, 2024

The decision on when to include a file in LFS was getting a bit annoying, and sometimes we forget. Just put it all in LFS.

We should update either the README or the docs at some point to include a small explanation on LFS too.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.24%. Comparing base (d98a557) to head (51f46b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #562      +/-   ##
==========================================
- Coverage   74.28%   74.24%   -0.04%     
==========================================
  Files         285      285              
  Lines       23605    23605              
==========================================
- Hits        17535    17526       -9     
- Misses       6070     6079       +9     
Flag Coverage Δ
unittests 74.24% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from pyrco March 5, 2024 00:28
@Schamper
Copy link
Member Author

Schamper commented Mar 5, 2024

Hm this does remove the ability to preview a (text based) test file in a PR, which is also very annoying.

@pyrco
Copy link
Contributor

pyrco commented Mar 7, 2024

Hm this does remove the ability to preview a (text based) test file in a PR, which is also very annoying.

That's an unfortunate side effect. Putting tests/_data/* in LFS is right thing to do I think. This is a shortcoming of GitHub and I'm leaning to not letting that stand in the way of the this.

@Schamper
Copy link
Member Author

Schamper commented Mar 7, 2024

Hm this does remove the ability to preview a (text based) test file in a PR, which is also very annoying.

That's an unfortunate side effect. Putting tests/_data/* in LFS is right thing to do I think. This is a shortcoming of GitHub and I'm leaning to not letting that stand in the way of the this.

Yes, agreed.

@Schamper Schamper force-pushed the lfs-all-the-things branch from 01402e1 to 51f46b5 Compare March 7, 2024 11:49
pyrco
pyrco previously approved these changes Apr 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.90%. Comparing base (ab8104f) to head (c427b90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #562   +/-   ##
=======================================
  Coverage   74.90%   74.90%           
=======================================
  Files         288      288           
  Lines       24115    24115           
=======================================
  Hits        18064    18064           
  Misses       6051     6051           
Flag Coverage Δ
unittests 74.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from pyrco April 8, 2024 19:58
@Schamper Schamper merged commit b2dd08c into main Apr 10, 2024
16 checks passed
@Schamper Schamper deleted the lfs-all-the-things branch April 10, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants