Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PyYAML with ruamel.yaml #563

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Replace PyYAML with ruamel.yaml #563

merged 5 commits into from
Mar 21, 2024

Conversation

Schamper
Copy link
Member

@Schamper Schamper commented Mar 5, 2024

PyYAML has been haunting me in my sleep ever since the early days of Dissect, it's time to get rid of it.

Fingers crossed that these files already had existing unit tests.

@Schamper Schamper requested a review from Miauwkeru March 5, 2024 01:06
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 64.51613% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 74.75%. Comparing base (04d3892) to head (2f72bf1).

Files Patch % Lines
dissect/target/helpers/network_managers.py 60.00% 6 Missing ⚠️
dissect/target/loaders/target.py 70.00% 3 Missing ⚠️
dissect/target/helpers/configutil.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #563      +/-   ##
==========================================
- Coverage   74.77%   74.75%   -0.03%     
==========================================
  Files         288      288              
  Lines       23928    23929       +1     
==========================================
- Hits        17893    17887       -6     
- Misses       6035     6042       +7     
Flag Coverage Δ
unittests 74.75% <64.51%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 6c0e2fc into main Mar 21, 2024
16 checks passed
@Schamper Schamper deleted the replace-pyyaml branch March 21, 2024 13:50
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants