Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom command support in MQTT-loader #569

Merged
merged 28 commits into from
Mar 14, 2024
Merged

Custom command support in MQTT-loader #569

merged 28 commits into from
Mar 14, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS- 2906)

cecinestpasunepipe and others added 26 commits February 27, 2024 15:27
@cecinestpasunepipe
WIP
ee6541c
@cecinestpasunepipe
Add tests.
b0b1c8a
@cecinestpasunepipe
Add types.
5406e86
@cecinestpasunepipe
Add types.
25a9bca
@cecinestpasunepipe
Update lru_cache.
cf7254d
@cecinestpasunepipe
Add dependency MQTT-PAHO.
dc5ca1b
@cecinestpasunepipe
Use posix_path for virtual path to child target.
8a3b128
@cecinestpasunepipe
Keep remoteloader, add separate mqttloader.
816459b
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
a759a53 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
505e82c 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe
Improvements
d1d6ae1
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
38823a8 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe
Improvements
ea08c00
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
5c76732 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
a6da357 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe @Miauwkeru
Update tests/loaders/test_mqtt.py
4faa1f4 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe
Improvements
8bf8c76
@cecinestpasunepipe
Improvements.
2f1ad6a
@cecinestpasunepipe
Improvements.
6556984
@cecinestpasunepipe
Improvements.
b250544
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
265f1cf 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe
Improvements.
dbb4e4a
@cecinestpasunepipe
Improvements.
2e570f5
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
2948bbc 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe @Miauwkeru
Update dissect/target/loaders/mqtt.py
0334aa1 
Co-authored-by: Miauwkeru <[email protected]>
@cecinestpasunepipe
Custom command support in MQTT-loader (DIS-2906)
6e64e45
@codecov Codecov
Copy link

codecov bot commented Mar 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.53498% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 74.51%. Comparing base (a87a5c5) to head (6e64e45).
Report is 8 commits behind head on main.

Files Patch % Lines
dissect/target/loaders/mqtt.py 90.36% 21 Missing ⚠️
dissect/target/plugins/child/mqtt.py 90.47% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   73.98%   74.51%   +0.53%     
==========================================
  Files         285      288       +3     
  Lines       23562    23854     +292     
==========================================
+ Hits        17432    17775     +343     
+ Misses       6130     6079      -51
Flag Coverage Δ
unittests 74.51% <90.53%> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2906_Custom_Command_MQTT branch from 6e64e45 to 98d628c Compare March 11, 2024 14:18
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.72%. Comparing base (5c61adf) to head (f9567d1).
Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/loaders/mqtt.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         288      288           
  Lines       23891    23895    +4     
=======================================
+ Hits        17852    17855    +3     
- Misses       6039     6040    +1
Flag Coverage Δ
unittests 74.72% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2906_Custom_Command_MQTT branch from 98d628c to 202d0a2 Compare March 12, 2024 14:15
@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2906_Custom_Command_MQTT branch from 202d0a2 to f9567d1 Compare March 12, 2024 14:16
@cecinestpasunepipe cecinestpasunepipe merged commit 5deff14 into main Mar 14, 2024
16 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2906_Custom_Command_MQTT branch March 14, 2024 15:02
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
@cecinestpasunepipe @Zawadidone
Custom command support in MQTT-loader (fox-it#569)
b39db87 
(DIS-2906)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miauwkeru Miauwkeru Miauwkeru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cecinestpasunepipe @codecov-commenter @Miauwkeru