Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target dump not handling namespaced plugins #579

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

Miauwkeru
Copy link
Contributor

  • Use the find_plugins function to search for plugins
  • Change type information

(DIS-2743)

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.84%. Comparing base (ed13639) to head (cb66b15).

Files Patch % Lines
dissect/target/tools/dump/run.py 91.66% 1 Missing ⚠️
dissect/target/tools/dump/utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #579      +/-   ##
==========================================
+ Coverage   74.75%   74.84%   +0.09%     
==========================================
  Files         288      288              
  Lines       23930    23932       +2     
==========================================
+ Hits        17888    17912      +24     
+ Misses       6042     6020      -22     
Flag Coverage Δ
unittests 74.84% <94.59%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru force-pushed the target-dump-not-handling-namespaced-plugins branch from 38a6575 to cb66b15 Compare March 25, 2024 08:20
@Miauwkeru Miauwkeru linked an issue Mar 25, 2024 that may be closed by this pull request
@Miauwkeru Miauwkeru merged commit 2182884 into main Mar 25, 2024
16 checks passed
@Miauwkeru Miauwkeru deleted the target-dump-not-handling-namespaced-plugins branch March 25, 2024 09:06
Zawadidone pushed a commit to Zawadidone/dissect.target that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

target-dump not working for the amcache function
3 participants