Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yield MFT segments in specified range #672

Merged
merged 16 commits into from
Aug 7, 2024

Conversation

Zawadidone
Copy link
Contributor

Closes #665

@Zawadidone Zawadidone marked this pull request as ready for review May 6, 2024 12:09
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Zawadidone, thanks for your contribution! 😄

I have some small change requests, please see below.

@Zawadidone Zawadidone requested a review from Poeloe August 5, 2024 12:44
@Zawadidone Zawadidone requested a review from Poeloe August 6, 2024 09:39
Poeloe
Poeloe previously approved these changes Aug 6, 2024
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 75.45%. Comparing base (fabbdf9) to head (f3a8ddc).

Files Patch % Lines
dissect/target/plugins/filesystem/ntfs/mft.py 77.27% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
- Coverage   75.45%   75.45%   -0.01%     
==========================================
  Files         296      296              
  Lines       25629    25643      +14     
==========================================
+ Hits        19339    19348       +9     
- Misses       6290     6295       +5     
Flag Coverage Δ
unittests 75.45% <77.27%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Poeloe
Poeloe previously approved these changes Aug 7, 2024
@Zawadidone Zawadidone requested review from Poeloe and Schamper August 7, 2024 14:19
@Horofic Horofic merged commit 22d1ca8 into fox-it:main Aug 7, 2024
18 checks passed
@Zawadidone Zawadidone deleted the feature/mft_segments branch August 7, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse MFT records based on segment numbers
4 participants