Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public key fingerprints to ssh plugins #673

Merged
merged 7 commits into from
Apr 11, 2024

Conversation

JSCU-CNI
Copy link
Contributor

This PR adds public key fingerprints (md5, sha1 and sha256) to the existing ssh plugins.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.93%. Comparing base (569e8f1) to head (2e123e6).

Files Patch % Lines
dissect/target/plugins/apps/ssh/ssh.py 83.33% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   74.90%   74.93%   +0.02%     
==========================================
  Files         288      288              
  Lines       24115    24145      +30     
==========================================
+ Hits        18064    18093      +29     
- Misses       6051     6052       +1     
Flag Coverage Δ
unittests 74.93% <91.89%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit f433711 into fox-it:main Apr 11, 2024
16 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/ssh-fingerprints branch August 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants