Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError in iexplore.downloads down_path #676

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

JSCU-CNI
Copy link
Contributor

This PR fixes an error in the iexplore.downloads function.

When container_record.ResponseHeaders does not exist or fails to be decoded, the variable down_path stays set to None. When passing None to self.target.fs.path / TargetPath we get an ugly exception.

This is fixed by properly checking if down_path is truthy before calling self.target.fs.path.

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.90%. Comparing base (45bbc26) to head (a5addac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   74.90%   74.90%           
=======================================
  Files         288      288           
  Lines       24115    24115           
=======================================
  Hits        18064    18064           
  Misses       6051     6051           
Flag Coverage Δ
unittests 74.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 569e8f1 into fox-it:main Apr 11, 2024
16 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/iexplore-downloads branch August 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants