Fix TypeError in iexplore.downloads down_path
#676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an error in the
iexplore.downloads
function.When
container_record.ResponseHeaders
does not exist or fails to be decoded, the variabledown_path
stays set toNone
. When passingNone
toself.target.fs.path
/TargetPath
we get an ugly exception.This is fixed by properly checking if
down_path
is truthy before callingself.target.fs.path
.