Add retrieval browser data "Snapshots" folder #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mick-314
force-pushed
the
fix/include-browser-snapshots-folder
branch
from
6a813b9 to
d225650
Compare
…Edge browsers on Windows.
mick-314
force-pushed
the
fix/include-browser-snapshots-folder
branch
from
d225650 to
fc00fbc
Compare
Horofic
approved these changes
Jul 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #680 +/- ##
==========================================
- Coverage 75.06% 75.06% -0.01%
==========================================
Files 295 295
Lines 25081 25082 +1
==========================================
Hits 18828 18828
- Misses 6253 6254 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain browsers create snapshots during major version updates. These snapshots allow for rollbacks and contain user data, and are thus interesting to take into account as well when retrieving browser information. This PR adds functionality to also retrieve user data from the "Snapshots" directory for the browsers Chrome and Edge.
See the following links for more some context:
This PR adds a globbing feature to the
ChromiumMixinclass, which theChromePluginandEdgePluginclasses both inherit from._build_userdirs()now supports globbing, andEdgePluginandChromePluginhave the wildcard paths that take into account the browser snapshots in the "Snapshots" folder.Resolves #679.