Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split runkey path as command components #688

Merged
merged 3 commits into from
May 3, 2024

Conversation

Miauwkeru
Copy link
Contributor

  • Use command type for runkeys
  • Enable --hash for command types

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.19%. Comparing base (b1bcb0d) to head (cbd41ce).
Report is 1 commits behind head on main.

Files Patch % Lines
dissect/target/helpers/record_modifier.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
- Coverage   75.19%   75.19%   -0.01%     
==========================================
  Files         292      292              
  Lines       24836    24839       +3     
==========================================
+ Hits        18676    18678       +2     
- Misses       6160     6161       +1     
Flag Coverage Δ
unittests 75.19% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru force-pushed the DIS-2562_runkey-path-as-command-components branch from 265a340 to cbd41ce Compare May 3, 2024 11:59
@Miauwkeru Miauwkeru merged commit 90fa8ae into main May 3, 2024
16 checks passed
@Miauwkeru Miauwkeru deleted the DIS-2562_runkey-path-as-command-components branch May 3, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runkey "path" needs to be parsed into command components
3 participants