Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return descriptive error when target tools point to a non-existing file #702

Merged
merged 2 commits into from
May 15, 2024

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented May 7, 2024

(DIS-2565)

@Poeloe Poeloe requested a review from Schamper May 7, 2024 07:55
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 75.19%. Comparing base (90fa8ae) to head (5e5d117).

Files Patch % Lines
dissect/target/loaders/raw.py 80.00% 1 Missing ⚠️
dissect/target/target.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #702   +/-   ##
=======================================
  Coverage   75.19%   75.19%           
=======================================
  Files         292      292           
  Lines       24839    24848    +9     
=======================================
+ Hits        18678    18685    +7     
- Misses       6161     6163    +2     
Flag Coverage Δ
unittests 75.19% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poeloe Poeloe requested a review from Schamper May 13, 2024 00:30
@Poeloe Poeloe force-pushed the feature/return-descriptive-error-non-existing-file branch from dba2107 to 5e5d117 Compare May 13, 2024 00:32
@Poeloe Poeloe merged commit 3bca243 into main May 15, 2024
16 checks passed
@Poeloe Poeloe deleted the feature/return-descriptive-error-non-existing-file branch May 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants