Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monitoring option to MQTT Loader #709

Merged
merged 8 commits into from
May 23, 2024
Merged

Add monitoring option to MQTT Loader #709

merged 8 commits into from
May 23, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-3213)

@cecinestpasunepipe cecinestpasunepipe requested a review from pyrco May 16, 2024 10:58
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2024

Codecov Report

Attention: Patch coverage is 24.00000% with 76 lines in your changes are missing coverage. Please review.

Project coverage is 74.96%. Comparing base (b514c07) to head (2134ec5).

Files Patch % Lines
dissect/target/loaders/mqtt.py 24.00% 76 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   75.17%   74.96%   -0.21%     
==========================================
  Files         292      292              
  Lines       24857    24955      +98     
==========================================
+ Hits        18686    18708      +22     
- Misses       6171     6247      +76     
Flag Coverage Δ
unittests 74.96% <24.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe merged commit 4962256 into main May 23, 2024
16 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-3213 branch May 23, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants