Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AnyDesk plugin #712

Merged
merged 10 commits into from
Jul 25, 2024

Conversation

JSCU-CNI
Copy link
Contributor

This PR improves the AnyDesk plugin:

  • add try/except handler for malformed log lines
  • add more trace log paths
  • improve accuracy of record timestamps
  • better handle decode errors
  • add larger log file for tests

@JSCU-CNI JSCU-CNI requested a review from Schamper July 24, 2024 10:14
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.08%. Comparing base (22eed46) to head (7e8ad38).

Files Patch % Lines
...issect/target/plugins/apps/remoteaccess/anydesk.py 86.66% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   75.07%   75.08%           
=======================================
  Files         294      294           
  Lines       25091    25106   +15     
=======================================
+ Hits        18837    18850   +13     
- Misses       6254     6256    +2     
Flag Coverage Δ
unittests 75.08% <92.59%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 951fc57 into fox-it:main Jul 25, 2024
17 of 18 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/anydesk-exception-handling branch July 25, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants