Fix edge case where unix history path is a directory #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, on first sight this looks good. We'll try to process this PR asap. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 74.92% 74.92%
=======================================
Files 295 295
Lines 25065 25065
=======================================
Hits 18781 18781
Misses 6284 6284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pyrco
approved these changes
Jun 27, 2024
pyrco
force-pushed
the
fix-unix-history-directory
branch
from
b4155ce to
5ba00ec
Compare
otnxSl
pushed a commit
to otnxSl/dissect.target
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the edge case where the path of a unix history file is a directory, the unix history plugin fails as it only checks the path exists and, if so, assumes it is a file. This PR fixes this problem by explicitly checking the path is a file.