Add glob/dump function for config tree #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
- Coverage 75.01% 74.92% -0.09%
==========================================
Files 294 295 +1
Lines 25018 25065 +47
==========================================
+ Hits 18768 18781 +13
- Misses 6250 6284 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Miauwkeru
reviewed
Jun 20, 2024
cecinestpasunepipe
force-pushed
the
DIS-2163_Unix_Config_Globber
branch
from
a7e8b10 to
cef9894
Compare
cecinestpasunepipe
force-pushed
the
DIS-2163_Unix_Config_Globber
branch
from
336aa39 to
6e15966
Compare
Miauwkeru
approved these changes
Jun 26, 2024
Miauwkeru
approved these changes
Jun 26, 2024
Schamper
reviewed
Jul 1, 2024
| if isinstance(config_object, ConfigurationEntry): | ||
| yield from self._sub(config_object, Path(entry) / Path(item), pattern) | ||
| except Exception: | ||
| log.warning("Could not open configuration item: %s", item) |
There was a problem hiding this comment.
Needs to be self.target.log, can you create a PR to fix that?
otnxSl
pushed a commit
to otnxSl/dissect.target
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-2990)