Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add username and password options to MQTT loader #732

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-3240)

@cecinestpasunepipe cecinestpasunepipe requested a review from pyrco June 25, 2024 16:17
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.97%. Comparing base (e6a457a) to head (2cc6e10).

Files Patch % Lines
dissect/target/loaders/mqtt.py 81.81% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   74.97%   74.97%           
=======================================
  Files         295      295           
  Lines       25070    25080   +10     
=======================================
+ Hits        18796    18804    +8     
- Misses       6274     6276    +2     
Flag Coverage Δ
unittests 74.97% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe requested a review from pyrco June 28, 2024 10:09
@cecinestpasunepipe cecinestpasunepipe merged commit 64db578 into main Jul 1, 2024
17 of 18 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-3240_ACL branch July 1, 2024 11:26
otnxSl pushed a commit to otnxSl/dissect.target that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants