Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Env ConfigurationParser #733

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Jun 27, 2024

This PR adds an environment file parser to the ConfigurationParser helper utility. Fixes #888.

@Miauwkeru
Copy link
Contributor

Thanks for the contribution! We'll discuss these changes with the team and come back to you. Nice to see people using the configuration parser at least :)

@JSCU-CNI JSCU-CNI force-pushed the feature/add-env-file-parser branch from acde5ec to 8a27fbb Compare September 25, 2024 12:52
@cecinestpasunepipe cecinestpasunepipe force-pushed the feature/add-env-file-parser branch from 8a27fbb to 6fb4dfe Compare October 15, 2024 09:04
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 88.70968% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.68%. Comparing base (e86f92e) to head (6fb4dfe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/helpers/configutil.py 89.18% 4 Missing ⚠️
dissect/target/plugins/apps/other/env.py 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
+ Coverage   76.66%   76.68%   +0.02%     
==========================================
  Files         314      315       +1     
  Lines       26955    27017      +62     
==========================================
+ Hits        20664    20719      +55     
- Misses       6291     6298       +7     
Flag Coverage Δ
unittests 76.68% <88.70%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe merged commit 430d14c into fox-it:main Oct 15, 2024
18 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the feature/add-env-file-parser branch October 15, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an environment file configuration parser
3 participants