Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unhandled filesystem exceptions in modify_record #737

Merged

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Jul 3, 2024

This PR prevents unhandled underlying filesystem exceptions when calling a record modifier function. We now check if the resolved_path exists and is a file before attempting to open it.

This is a workaround for the issues discussed in #684.

@JSCU-CNI JSCU-CNI force-pushed the fix/modify-record-filesystem-exceptions branch from a34e74f to 3820004 Compare August 12, 2024 12:18
@JSCU-CNI JSCU-CNI requested review from Miauwkeru and Schamper August 19, 2024 11:07
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.54%. Comparing base (f76ac8c) to head (1d92e33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #737   +/-   ##
=======================================
  Coverage   75.54%   75.54%           
=======================================
  Files         305      305           
  Lines       26331    26334    +3     
=======================================
+ Hits        19891    19894    +3     
  Misses       6440     6440           
Flag Coverage Δ
unittests 75.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru merged commit 6894023 into fox-it:main Aug 20, 2024
18 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/modify-record-filesystem-exceptions branch August 20, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent unhandled filesystem exceptions in modify_record PR#737
3 participants