Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TargetPath instances for configutil.parse #743

Merged

Conversation

Miauwkeru
Copy link
Contributor

closes #719

@Miauwkeru Miauwkeru linked an issue Jul 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.96%. Comparing base (8bf15d7) to head (f2a9d88).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   74.96%   74.96%           
=======================================
  Files         295      295           
  Lines       25083    25083           
=======================================
+ Hits        18803    18804    +1     
+ Misses       6280     6279    -1     
Flag Coverage Δ
unittests 74.96% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru force-pushed the 719-config-parser-does-not-work-with-targetpath-instances branch from 8cd2135 to f2a9d88 Compare July 5, 2024 13:03
@Miauwkeru Miauwkeru merged commit 085e324 into main Jul 9, 2024
17 of 18 checks passed
@Miauwkeru Miauwkeru deleted the 719-config-parser-does-not-work-with-targetpath-instances branch July 9, 2024 08:32
otnxSl pushed a commit to otnxSl/dissect.target that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config parser does not work with TargetPath instances
2 participants