Add support for Firefox Oculus VR browser #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
+ Coverage 75.23% 75.26% +0.02%
==========================================
Files 296 296
Lines 25556 25573 +17
==========================================
+ Hits 19228 19248 +20
+ Misses 6328 6325 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Schamper
force-pushed
the
firefox-vrbrowser
branch
from
ddcb80c to
4092327
Compare
Schamper
force-pushed
the
firefox-vrbrowser
branch
from
4092327 to
e28303c
Compare
Horofic
approved these changes
Aug 2, 2024
Miauwkeru
reviewed
Aug 2, 2024
| @@ -66,6 +70,10 @@ class FirefoxPlugin(BrowserPlugin): | |||
| "Library/Application Support/Firefox", | |||
| ] | |||
|
|
|||
| SYSTEM_DIRS = [ | |||
| "/data/data/org.mozilla.vrbrowser/files/mozilla", | |||
There was a problem hiding this comment.
just a random question, is there a difference between the normal android firefox browser and the vrbrowser except for the uri in the path?
There was a problem hiding this comment.
I don't have an Android device to verify this with at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on and separated from #419