Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move helpers from './helpers/ssh.py' into './plugins/apps/ssh/ssh.py' #756

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Jul 23, 2024

(DIS-3217)

@Poeloe Poeloe requested a review from pyrco July 23, 2024 11:05
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.06%. Comparing base (9ae4549) to head (e5ae2c9).

Files Patch % Lines
dissect/target/plugins/apps/ssh/ssh.py 93.33% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   75.06%   75.06%   -0.01%     
==========================================
  Files         295      294       -1     
  Lines       25082    25080       -2     
==========================================
- Hits        18828    18826       -2     
  Misses       6254     6254              
Flag Coverage Δ
unittests 75.06% <93.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poeloe Poeloe force-pushed the feature/move-ssh-helpers-to-ssh-app-location branch from e7b5f3f to e5ae2c9 Compare July 23, 2024 11:11
@Poeloe Poeloe changed the title Draft: Move helpers from './helpers/ssh.py' into './plugins/apps/ssh/ssh.py' Move helpers from './helpers/ssh.py' into './plugins/apps/ssh/ssh.py' Jul 23, 2024
@Poeloe Poeloe merged commit 80bce06 into main Jul 24, 2024
17 of 18 checks passed
@Poeloe Poeloe deleted the feature/move-ssh-helpers-to-ssh-app-location branch July 24, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants