-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix directory argument for lnk plugin #757
Conversation
974268c
to
3103770
Compare
3103770
to
6a96855
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 75.07% 75.08%
=======================================
Files 294 294
Lines 25107 25113 +6
=======================================
+ Hits 18850 18857 +7
+ Misses 6257 6256 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a small test to test this new behavior. Also, the dissect.shellitems
project has a tool called parse-lnk
could you check if that tool handles directories correctly?
No description provided.