Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix directory argument for lnk plugin #757

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Jul 23, 2024

No description provided.

@Poeloe Poeloe requested a review from Horofic July 23, 2024 13:10
@Poeloe Poeloe force-pushed the fix/fix-directory-argument-for-lnk-plugin branch from 974268c to 3103770 Compare July 23, 2024 13:12
@Poeloe Poeloe force-pushed the fix/fix-directory-argument-for-lnk-plugin branch from 3103770 to 6a96855 Compare July 23, 2024 13:13
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.08%. Comparing base (1ae1b4a) to head (da96c7f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   75.07%   75.08%           
=======================================
  Files         294      294           
  Lines       25107    25113    +6     
=======================================
+ Hits        18850    18857    +7     
+ Misses       6257     6256    -1     
Flag Coverage Δ
unittests 75.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Horofic Horofic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a small test to test this new behavior. Also, the dissect.shellitems project has a tool called parse-lnk could you check if that tool handles directories correctly?

@Poeloe Poeloe requested a review from Horofic July 25, 2024 09:27
@Horofic Horofic merged commit 9823ec5 into main Jul 26, 2024
17 of 18 checks passed
@Horofic Horofic deleted the fix/fix-directory-argument-for-lnk-plugin branch July 26, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants