Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong log logic indicating a sysvol was not found #762

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Jul 25, 2024

No description provided.

@pyrco pyrco requested a review from Poeloe July 25, 2024 11:37
@pyrco pyrco linked an issue Jul 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.07%. Comparing base (951fc57) to head (7258999).

Files Patch % Lines
dissect/target/plugins/os/windows/_os.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   75.08%   75.07%   -0.01%     
==========================================
  Files         294      294              
  Lines       25106    25107       +1     
==========================================
  Hits        18850    18850              
- Misses       6256     6257       +1     
Flag Coverage Δ
unittests 75.07% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pyrco pyrco force-pushed the fix-wrong-sysvol-not-found-log branch from b7a8372 to 7258999 Compare July 25, 2024 14:21
@pyrco pyrco merged commit 8b15b57 into main Jul 25, 2024
16 of 18 checks passed
@pyrco pyrco deleted the fix-wrong-sysvol-not-found-log branch July 25, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows os plugin wrongly issues "No sysvol drive found" warning
2 participants