Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _target field to firefox and chromium plugins #764

Merged

Conversation

DevJoost
Copy link
Contributor

The browser.cookies plugin returned records without target information for Firefox and Chromium browsers.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.07%. Comparing base (8b15b57) to head (8eee22d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage   75.07%   75.07%           
=======================================
  Files         294      294           
  Lines       25107    25107           
=======================================
  Hits        18850    18850           
  Misses       6257     6257           
Flag Coverage Δ
unittests 75.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 1ae1b4a into fox-it:main Jul 26, 2024
17 of 18 checks passed
@DevJoost DevJoost deleted the bug/missing_target_info_browser_cookies branch July 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants