Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Windows USB plugin #766

Merged

Conversation

JSCU-CNI
Copy link
Contributor

This PR rewrites the existing Windows USB plugin and adds a test based on a Windows 10 22H2 system.

@Schamper Schamper changed the title Rewrite windows usb plugin Rewrite Windows USB plugin Jul 29, 2024
Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also didn't check myself but was curious how this might compare to https://github.com/khyrenz/parseusbs.

@JSCU-CNI
Copy link
Contributor Author

I also didn't check myself but was curious how this might compare to https://github.com/khyrenz/parseusbs.

I haven't tested that tool specifically. Looking at the code it seems to use some more registry artifacts than the UsbPlugin currently does. Could you create a ticket for this? We can revisit this in the future.

@Schamper
Copy link
Member

I haven't tested that tool specifically. Looking at the code it seems to use some more registry artifacts than the UsbPlugin currently does. Could you create a ticket for this? We can revisit this in the future.

Created with #777

@JSCU-CNI JSCU-CNI requested a review from Schamper August 1, 2024 07:52
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 74.11765% with 22 lines in your changes missing coverage. Please review.

Project coverage is 75.34%. Comparing base (793cfc6) to head (184d1f9).

Files Patch % Lines
dissect/target/plugins/os/windows/regf/usb.py 74.11% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
+ Coverage   75.24%   75.34%   +0.09%     
==========================================
  Files         296      296              
  Lines       25434    25472      +38     
==========================================
+ Hits        19139    19193      +54     
+ Misses       6295     6279      -16     
Flag Coverage Δ
unittests 75.34% <74.11%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 4d376f2 into fox-it:main Aug 1, 2024
17 of 18 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/refactor-windows-usb-plugin branch August 1, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants