Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MACB aggregator to MFT #767

Merged
merged 9 commits into from
Aug 1, 2024
Merged

Add MACB aggregator to MFT #767

merged 9 commits into from
Aug 1, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-2755)

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.37%. Comparing base (4d376f2) to head (2fab41a).

Files Patch % Lines
dissect/target/plugins/filesystem/ntfs/mft.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
+ Coverage   75.34%   75.37%   +0.02%     
==========================================
  Files         296      296              
  Lines       25472    25503      +31     
==========================================
+ Hits        19193    19223      +30     
- Misses       6279     6280       +1     
Flag Coverage Δ
unittests 75.37% <97.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe changed the title Add MCAB-formatting to MFT Add MACB aggregator to MFT Jul 30, 2024
@Schamper Schamper removed their request for review July 31, 2024 12:15
@Schamper Schamper dismissed their stale review July 31, 2024 12:15

Dismissed

@Schamper Schamper removed their request for review July 31, 2024 15:06
@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2755_MFT branch 3 times, most recently from 0d4e74f to a79b6c9 Compare July 31, 2024 17:01
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cecinestpasunepipe cecinestpasunepipe merged commit ced08e4 into main Aug 1, 2024
18 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2755_MFT branch August 1, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants