Add option to scan children in YARA plugin #780
Conversation
dissect/target/tools/yara.py
Outdated
| for target in Target.open_all(args.targets): | ||
| target.log.info("Scanning target") | ||
| for target in Target.open_all(args.targets, args.children): | ||
| target.log.info("Scanning target %s", target) |
There was a problem hiding this comment.
Because you use target.log, it should already include the target repr in the log line, does logging it again really help?
There was a problem hiding this comment.
Agreed, removed in 870e9db.
There was a problem hiding this comment.
Now you removed the entire log line, was that intended? My comment was towards the additional %s of the target object.
There was a problem hiding this comment.
Yes I think the entire line is unnecessary due to additional logging by the filesystem.yara plugin
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #780 +/- ##
=======================================
Coverage 75.23% 75.23%
=======================================
Files 296 296
Lines 25556 25556
=======================================
Hits 19228 19228
Misses 6328 6328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This is a small improvement on #646 that adds
--childrentotarget-yara/target-query -f yara.