Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader option to target-info and target-yara #781

Merged

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Aug 1, 2024

This PR adds the --loader / -L option to target-info and target-yara. Also adds a test for target-info since that did not exist yet.

@Schamper
Copy link
Member

Schamper commented Aug 1, 2024

Can you fix the merge conflict?

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (e81cee1) to head (b486479).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   75.26%   75.41%   +0.14%     
==========================================
  Files         296      296              
  Lines       25584    25587       +3     
==========================================
+ Hits        19257    19297      +40     
+ Misses       6327     6290      -37     
Flag Coverage Δ
unittests 75.41% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 79579c1 into fox-it:main Aug 5, 2024
18 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/target-info-yara-loader-option branch August 5, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants