Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --root to the etc plugin #783

Merged
merged 5 commits into from
Aug 5, 2024

Conversation

Miauwkeru
Copy link
Contributor

  • Fix MdVolumeSystem
  • Add root to etc plugin, look for entries relative to root
  • Make it consistent to use a configuration entry
  • Made the directory lookup work relatively

@Miauwkeru Miauwkeru force-pushed the DIS-3279_diferent-root-config-tree-plugin branch from 792f509 to 7e7e0e0 Compare August 1, 2024 16:32
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (5d19f13) to head (71c8e15).

Files Patch % Lines
dissect/target/filesystems/config.py 86.36% 3 Missing ⚠️
dissect/target/plugins/os/unix/etc/etc.py 50.00% 2 Missing ⚠️
dissect/target/helpers/configutil.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #783   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files         296      296           
  Lines       25575    25584    +9     
=======================================
+ Hits        19248    19257    +9     
  Misses       6327     6327           
Flag Coverage Δ
unittests 75.26% <77.77%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miauwkeru Miauwkeru force-pushed the DIS-3279_diferent-root-config-tree-plugin branch from a6459f1 to 71c8e15 Compare August 5, 2024 11:26
@Miauwkeru Miauwkeru merged commit e81cee1 into main Aug 5, 2024
18 checks passed
@Miauwkeru Miauwkeru deleted the DIS-3279_diferent-root-config-tree-plugin branch August 5, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants