Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with pathless config items #785

Merged
merged 12 commits into from
Nov 21, 2024
Merged

Fix issue with pathless config items #785

merged 12 commits into from
Nov 21, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (6e6a546) to head (b4b3266).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/unix/etc/etc.py 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
- Coverage   77.90%   77.90%   -0.01%     
==========================================
  Files         324      324              
  Lines       27850    27852       +2     
==========================================
+ Hits        21696    21697       +1     
- Misses       6154     6155       +1     
Flag Coverage Δ
unittests 77.90% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Miauwkeru
Copy link
Contributor

alternatively you can just pass config_object.entry.path to self._sub in def etc

Copy link
Contributor

@Miauwkeru Miauwkeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also first rebase and fix the conflicts.

@cecinestpasunepipe cecinestpasunepipe merged commit 8785906 into main Nov 21, 2024
16 of 20 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the fix/etc_path branch November 21, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants