Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for MSSQL error log files #823

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Added support for MSSQL error log files #823

merged 6 commits into from
Nov 14, 2024

Conversation

fox-evv
Copy link
Contributor

@fox-evv fox-evv commented Aug 15, 2024

This can show e.g. that xp_cmdshell was enabled

fox-evv and others added 2 commits August 15, 2024 16:16
This can show e.g. that xp_cmdshell was enabled
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.34%. Comparing base (a899df6) to head (336d8f3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/log/mssql.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   77.03%   74.34%   -2.69%     
==========================================
  Files         322      323       +1     
  Lines       27604    27641      +37     
==========================================
- Hits        21265    20551     -714     
- Misses       6339     7090     +751     
Flag Coverage Δ
unittests 74.34% <97.29%> (-2.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic self-assigned this Sep 9, 2024
@Horofic Horofic self-requested a review September 9, 2024 11:46
Copy link
Contributor

@Horofic Horofic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions and added some tests with a commit. Please test in your own environment to see if the suggestions hold up.

Horofic
Horofic previously approved these changes Nov 14, 2024
@Horofic Horofic merged commit ff97254 into fox-it:main Nov 14, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants