Add mutual exclusive plugin arguments #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 75.51% 75.53% +0.01%
==========================================
Files 305 305
Lines 26348 26356 +8
==========================================
+ Hits 19897 19907 +10
+ Misses 6451 6449 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Poeloe
requested changes
Sep 3, 2024
cecinestpasunepipe
force-pushed
the
DIS-3388_Mutual_exclusive_plugin_args
branch
from
2b37c8d to
d39c27a
Compare
Schamper
reviewed
Sep 5, 2024
| @@ -77,3 +78,17 @@ def test_plugin_name_confusion_regression(target_unix_users, pattern, expected_f | |||
| get_target_attribute(target_unix_users, plugins[0]) | |||
|
|
|||
| assert expected_function in str(exc_info.value) | |||
|
|
|||
|
|
|||
| def test_plugin_mutual_exclusive_arguments(): | |||
There was a problem hiding this comment.
Suggested change
| def test_plugin_mutual_exclusive_arguments(): | |
| def test_plugin_mutual_exclusive_arguments() -> None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(DIS-3388)