Dis 3281/improved security scheme #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 75.61% 75.59% -0.03%
==========================================
Files 311 311
Lines 26551 26561 +10
==========================================
+ Hits 20077 20078 +1
- Misses 6474 6483 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cecinestpasunepipe
suggested changes
Sep 11, 2024
dissect/target/loaders/mqtt.py
Outdated
| return | ||
|
|
||
| # The payload with the username and password is comma separated | ||
| print(f'CALLID: "{hostname}",{decoded_payload}') |
There was a problem hiding this comment.
please leave out the prefix here
dissect/target/loaders/mqtt.py
Outdated
| self.mqtt_client.publish(f"{self.case}/{host}/COMM", self.command.encode("utf-8")) | ||
| time.sleep(1) | ||
|
|
||
| def _on_callId(self, hostname: str, payload: bytes) -> None: |
There was a problem hiding this comment.
Suggested change
| def _on_callId(self, hostname: str, payload: bytes) -> None: | |
| def _on_call_id(self, hostname: str, payload: bytes) -> None: |
please use snake_case
dissect/target/loaders/mqtt.py
Outdated
| @@ -365,6 +376,8 @@ def _on_message(self, client: mqtt.Client, userdata: Any, msg: mqtt.client.MQTTM | |||
| self._on_read(hostname, tokens, msg.payload) | |||
| elif response == "ID": | |||
| self._on_id(hostname, msg.payload) | |||
| elif response == "CALLID": | |||
| self._on_callId(hostname, msg.payload) | |||
There was a problem hiding this comment.
change function call here please to match updated version
twiggler
force-pushed
the
dis-3281/improved-security-scheme
branch
from
3874eae to
854d39c
Compare
In response, print username and password to stdout.
twiggler
force-pushed
the
dis-3281/improved-security-scheme
branch
from
854d39c to
5026402
Compare
cecinestpasunepipe
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a companion PR of the agent and cannot be tested stand-alone.
To test together with the agent,
closes #846