Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfold ADS macb records #861

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Conversation

cecinestpasunepipe
Copy link
Contributor

Avoids hiding several ADS MACBs behind the same TS.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (6d0ddd0) to head (5e4239d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #861   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files         312      312           
  Lines       26789    26790    +1     
=======================================
+ Hits        20431    20432    +1     
  Misses       6358     6358           
Flag Coverage Δ
unittests 76.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper
Copy link
Member

Can you add a regression test?

@cecinestpasunepipe cecinestpasunepipe force-pushed the feature/unfold_ads_mft_macb branch from 565ffad to 2d3cafd Compare September 24, 2024 18:04
@Schamper Schamper removed their request for review September 25, 2024 11:07
@cecinestpasunepipe cecinestpasunepipe force-pushed the feature/unfold_ads_mft_macb branch 2 times, most recently from 0c1a913 to 11635ee Compare September 26, 2024 15:14
Copy link
Contributor

@Poeloe Poeloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cecinestpasunepipe cecinestpasunepipe force-pushed the feature/unfold_ads_mft_macb branch from e5c051b to 5e4239d Compare October 3, 2024 11:11
@cecinestpasunepipe cecinestpasunepipe merged commit e1acf1a into main Oct 3, 2024
18 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the feature/unfold_ads_mft_macb branch October 3, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants