Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for runtime aliases to target_shell #871

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-2965)

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.31%. Comparing base (e1acf1a) to head (ad89a3e).

Files with missing lines Patch % Lines
dissect/target/tools/shell.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
+ Coverage   76.26%   76.31%   +0.05%     
==========================================
  Files         312      312              
  Lines       26790    26822      +32     
==========================================
+ Hits        20432    20470      +38     
+ Misses       6358     6352       -6     
Flag Coverage Δ
unittests 76.31% <96.87%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2965_Aliases branch 4 times, most recently from fd76190 to da88108 Compare October 1, 2024 13:04
@EinatFox EinatFox linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link
Contributor

@twiggler twiggler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA:

When entering the unknown command ee,

Actual I am getting the following error when entering an unknown command:

image

Expected:

*** Unknown syntax: ee

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2965_Aliases branch 2 times, most recently from d747a8b to b4c92bf Compare October 3, 2024 11:21
twiggler
twiggler previously approved these changes Oct 3, 2024
@twiggler
Copy link
Contributor

twiggler commented Oct 3, 2024

@cecinestpasunepipe One small QA issue

When I run alias "./"="echo roel", the alias is defined (although it cannot be used yet):

image

Not that important but a bit weird.

@cecinestpasunepipe cecinestpasunepipe merged commit 28acbef into main Oct 3, 2024
18 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2965_Aliases branch October 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for alias functions for target-shell
2 participants