Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binary configuration parser #893

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-2162)

@cecinestpasunepipe cecinestpasunepipe marked this pull request as draft October 8, 2024 10:29
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.66%. Comparing base (bea348a) to head (15f8db6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/filesystems/config.py 50.00% 1 Missing ⚠️
dissect/target/helpers/configutil.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
- Coverage   76.66%   76.66%   -0.01%     
==========================================
  Files         314      314              
  Lines       26948    26955       +7     
==========================================
+ Hits        20659    20664       +5     
- Misses       6289     6291       +2     
Flag Coverage Δ
unittests 76.66% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe force-pushed the DIS-2162_Misc_Config branch 2 times, most recently from 4cdb008 to 6e0b3f9 Compare October 8, 2024 11:54
@cecinestpasunepipe cecinestpasunepipe marked this pull request as ready for review October 8, 2024 13:38
@Schamper
Copy link
Member

Schamper commented Oct 8, 2024

Can you change the title to something useful?

@EinatFox EinatFox linked an issue Oct 9, 2024 that may be closed by this pull request
@cecinestpasunepipe cecinestpasunepipe changed the title Misc/Custom Parsers Binary configparser Oct 10, 2024
Copy link
Contributor

@pyrco pyrco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a test case for this I think.

@Schamper Schamper changed the title Binary configparser Add binary configuration parser Oct 11, 2024
@cecinestpasunepipe cecinestpasunepipe merged commit e86f92e into main Oct 15, 2024
18 of 20 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2162_Misc_Config branch October 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unix Config Parser: Misc/Custom
3 participants