Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map all registry value types to a standardized enum in regutil #899

Merged
merged 23 commits into from
Oct 15, 2024

Conversation

cecinestpasunepipe
Copy link
Contributor

(DIS-2090)

Copy link
Member

@Schamper Schamper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use existing Python concepts for caching/lazy execution. I've given an example using @cached_property, but any other common method would also suffice.

cecinestpasunepipe and others added 21 commits October 15, 2024 13:15
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.70%. Comparing base (430d14c) to head (e90067d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/helpers/regutil.py 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
+ Coverage   76.68%   76.70%   +0.01%     
==========================================
  Files         315      315              
  Lines       27017    27033      +16     
==========================================
+ Hits        20719    20735      +16     
  Misses       6298     6298              
Flag Coverage Δ
unittests 76.70% <97.29%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cecinestpasunepipe cecinestpasunepipe merged commit ebd38fe into main Oct 15, 2024
18 of 20 checks passed
@cecinestpasunepipe cecinestpasunepipe deleted the DIS-2090 branch October 15, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants