Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mounted GNOME Trash folders #906

Merged
merged 13 commits into from
Nov 22, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Oct 16, 2024

This PR adds mounted Trash folder support to the GNOME Trash plugin. Fixes #908.

@Horofic Horofic self-requested a review October 16, 2024 13:52
@JSCU-CNI JSCU-CNI requested a review from Horofic November 11, 2024 10:37
Horofic
Horofic previously approved these changes Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (8785906) to head (17da580).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #906   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files         324      324           
  Lines       27852    27857    +5     
=======================================
+ Hits        21697    21702    +5     
  Misses       6155     6155           
Flag Coverage Δ
unittests 77.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Horofic
Horofic previously approved these changes Nov 15, 2024
@Horofic Horofic requested a review from Schamper November 15, 2024 09:46
@JSCU-CNI JSCU-CNI requested review from Horofic and Schamper November 21, 2024 13:54
@Horofic Horofic merged commit 67d34fe into fox-it:main Nov 22, 2024
18 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/gnome-trash-mounts branch December 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search mounts for GNOME Trash folders
3 participants