Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure editor plugin namespace #915

Merged

Conversation

JSCU-CNI
Copy link
Contributor

This PR restructures the editor plugin namespace. The previous implementation deviated from our internal structure for this category of plugins. This patch paves the road for open sourcing more editor plugins.

@Horofic Horofic self-requested a review October 25, 2024 06:51
@Horofic Horofic self-assigned this Oct 25, 2024
@JSCU-CNI JSCU-CNI requested a review from Horofic October 28, 2024 10:54
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.75%. Comparing base (6c672fa) to head (57de95e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/apps/editor/editor.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   76.75%   76.75%   -0.01%     
==========================================
  Files         315      315              
  Lines       27126    27130       +4     
==========================================
+ Hits        20820    20823       +3     
- Misses       6306     6307       +1     
Flag Coverage Δ
unittests 76.75% <89.47%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic merged commit d0fa985 into fox-it:main Oct 28, 2024
17 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/restructure-editor-namespace branch October 28, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants