Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FortiManager OS support #921

Merged
merged 11 commits into from
Oct 31, 2024

Conversation

JSCU-CNI
Copy link
Contributor

This PR improves FortiManager OS support in dissect.

@Horofic Horofic self-assigned this Oct 30, 2024
Schamper
Schamper previously approved these changes Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 41.07143% with 33 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (88fe795) to head (2c8cd33).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...issect/target/plugins/os/unix/linux/fortios/_os.py 17.94% 32 Missing ⚠️
dissect/target/plugins/os/windows/_os.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
+ Coverage   76.98%   77.02%   +0.03%     
==========================================
  Files         322      322              
  Lines       27573    27575       +2     
==========================================
+ Hits        21228    21239      +11     
+ Misses       6345     6336       -9     
Flag Coverage Δ
unittests 77.02% <41.07%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper requested a review from Horofic October 31, 2024 13:59
@Schamper Schamper merged commit 3b60c96 into fox-it:main Oct 31, 2024
17 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/fortimanager-detection branch October 31, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants