Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 compatible exception code #930

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Conversation

Schamper
Copy link
Member

Closes #929

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 24.56140% with 43 lines in your changes missing coverage. Please review.

Project coverage is 77.01%. Comparing base (90cbaac) to head (603506e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/filesystems/xfs.py 0.00% 7 Missing ⚠️
dissect/target/filesystems/btrfs.py 0.00% 4 Missing ⚠️
dissect/target/filesystems/ffs.py 0.00% 4 Missing ⚠️
dissect/target/filesystems/jffs.py 0.00% 4 Missing ⚠️
dissect/target/filesystems/squashfs.py 0.00% 4 Missing ⚠️
dissect/target/filesystems/vmfs.py 0.00% 4 Missing ⚠️
dissect/target/filesystems/extfs.py 25.00% 3 Missing ⚠️
dissect/target/filesystems/smb.py 0.00% 3 Missing ⚠️
dissect/target/volume.py 25.00% 3 Missing ⚠️
dissect/target/filesystems/ntfs.py 50.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage   77.01%   77.01%           
=======================================
  Files         322      322           
  Lines       27566    27566           
=======================================
  Hits        21231    21231           
  Misses       6335     6335           
Flag Coverage Δ
unittests 77.01% <24.56%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper force-pushed the modernize-exceptions branch from de7305f to 50bece3 Compare October 31, 2024 09:51
@Schamper Schamper merged commit 2deded6 into main Nov 1, 2024
17 of 20 checks passed
@Schamper Schamper deleted the modernize-exceptions branch November 1, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Python 2 compatible exception code
2 participants