Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FortiOS test #945

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Add FortiOS test #945

merged 2 commits into from
Nov 15, 2024

Conversation

JSCU-CNI
Copy link
Contributor

This PR adds a FortiOS test to dissect.

@JSCU-CNI JSCU-CNI force-pushed the improvement/fortios-tests branch from 9ab6bbc to 1413ff0 Compare November 12, 2024 14:38
@Horofic Horofic self-assigned this Nov 14, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.50%. Comparing base (ff97254) to head (7cf60b4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...issect/target/plugins/os/unix/linux/fortios/_os.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
+ Coverage   77.06%   77.50%   +0.44%     
==========================================
  Files         323      323              
  Lines       27641    27647       +6     
==========================================
+ Hits        21301    21429     +128     
+ Misses       6340     6218     -122     
Flag Coverage Δ
unittests 77.50% <42.85%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Horofic Horofic merged commit 3ded20a into fox-it:main Nov 15, 2024
17 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the improvement/fortios-tests branch December 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants