Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dependency on dissect.fve for the full extra #949

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

pyrco
Copy link
Contributor

@pyrco pyrco commented Nov 18, 2024

No description provided.

@pyrco pyrco requested a review from Miauwkeru November 18, 2024 10:35
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.82%. Comparing base (1a2c8fe) to head (503b1cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #949      +/-   ##
==========================================
+ Coverage   77.50%   77.82%   +0.31%     
==========================================
  Files         323      323              
  Lines       27647    27647              
==========================================
+ Hits        21429    21517      +88     
+ Misses       6218     6130      -88     
Flag Coverage Δ
unittests 77.82% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrco pyrco merged commit d6eb12e into main Nov 18, 2024
18 of 20 checks passed
@pyrco pyrco deleted the add-dissect.fve-dependency branch November 18, 2024 11:30
@Zawadidone
Copy link
Contributor

@pyrco does this platform_python_implementation != 'PyPy' mean that dissect.fve does not work with PyPy, as part of dissect.target?

@Miauwkeru
Copy link
Contributor

@pyrco does this platform_python_implementation != 'PyPy' mean that dissect.fve does not work with PyPy, as part of dissect.target?

it does an or operation in this dependency fix, so first it evaluates whether it isn't windows, then it evaluates if it isn't pypy.

So it would come through on linux machines with pypy.

The check is like this to avoid it installing on windows that uses PyPy, as it gave issues. The logic is inverted however to let it install on other systems

@Zawadidone
Copy link
Contributor

Okay thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants