Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve cit plugin exception handling #961

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Dec 2, 2024

This PR aims to improve the robustness of the Windows CIT plugin by catching EOFError exceptions.

@JSCU-CNI JSCU-CNI changed the title Improve robustness of CIT parsing Improve cit plugin exception handling Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.87%. Comparing base (f36ce59) to head (f2fd534).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/regf/cit.py 31.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   77.89%   77.87%   -0.03%     
==========================================
  Files         325      325              
  Lines       27888    27899      +11     
==========================================
+ Hits        21724    21726       +2     
- Misses       6164     6173       +9     
Flag Coverage Δ
unittests 77.87% <31.25%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 4388f76 into fox-it:main Dec 3, 2024
16 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/cit-eoferror branch December 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants