Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve catroot plugin exception handling #962

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

JSCU-CNI
Copy link
Contributor

@JSCU-CNI JSCU-CNI commented Dec 2, 2024

This PR adds exception handling to the catroot plugin. This should prevent exceptions such as esedb NotImplementedErrors from crashing the plugin.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (4388f76) to head (4c86cdc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dissect/target/plugins/os/windows/catroot.py 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #962      +/-   ##
==========================================
- Coverage   77.87%   77.86%   -0.02%     
==========================================
  Files         325      325              
  Lines       27899    27904       +5     
==========================================
+ Hits        21726    21727       +1     
- Misses       6173     6177       +4     
Flag Coverage Δ
unittests 77.86% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit b681e75 into fox-it:main Dec 4, 2024
16 of 20 checks passed
@JSCU-CNI JSCU-CNI deleted the fix/catroot-exceptions branch December 4, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants