Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove paho from mqqt unit test #967

Merged
merged 1 commit into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ full = [
"zstandard",
]
dev = [
"dissect.target[full,mqtt,yara]",
"dissect.target[full,yara]",
"dissect.archive[dev]>=1.0.dev,<2.0.dev",
"dissect.btrfs[dev]>=1.0.dev,<2.0.dev",
"dissect.cim[dev]>=3.0.dev,<4.0.dev",
Expand Down
36 changes: 28 additions & 8 deletions tests/loaders/test_mqtt.py
Original file line number Diff line number Diff line change
@@ -1,22 +1,23 @@
from __future__ import annotations

import argparse
import sys
import time
from dataclasses import dataclass
from struct import pack
from typing import Iterator
from unittest.mock import MagicMock, patch

import paho.mqtt.client as mqtt
import pytest

from dissect.target import Target
from dissect.target.loaders.mqtt import Broker, MQTTConnection, case


class MQTTMock(MagicMock):
disks = []
hostname = ""
def __init__(self, *args, **kwargs) -> None:
super().__init__(*args, **kwargs)
self.disks: list = []
self.hostname: str = ""

def fill_disks(self, sizes: list[int]) -> None:
self.disks = []
Expand Down Expand Up @@ -51,6 +52,17 @@ def publish(self, topic: str, *args) -> None:
self.on_message(self, None, response)


@pytest.fixture
def mock_paho(monkeypatch: pytest.MonkeyPatch) -> Iterator[MagicMock]:
with monkeypatch.context() as m:
mock_paho = MagicMock()
m.setitem(sys.modules, "paho", mock_paho)
m.setitem(sys.modules, "paho.mqtt", mock_paho.mqtt)
m.setitem(sys.modules, "paho.mqtt.client", mock_paho.mqtt.client)

yield mock_paho


@dataclass
class MockSeekMessage:
data: bytes = b""
Expand Down Expand Up @@ -87,7 +99,7 @@ def mock_broker() -> Iterator[MockBroker]:
@patch.object(time, "sleep") # improve speed during test, no need to wait for peers
def test_remote_loader_stream(
time: MagicMock,
monkeypatch: pytest.MonkeyPatch,
mock_paho: MagicMock,
alias: str,
hosts: list[str],
disks: list[int],
Expand All @@ -96,7 +108,9 @@ def test_remote_loader_stream(
read: int,
expected: bytes,
) -> None:
monkeypatch.setattr(mqtt, "Client", MQTTMock)
mock_paho.mqtt.client.Client.return_value = MQTTMock()

from dissect.target.loaders.mqtt import Broker

broker = Broker("0.0.0.0", "1884", "key", "crt", "ca", "case1", "user", "pass")
broker.connect()
Expand All @@ -116,7 +130,9 @@ def test_remote_loader_stream(
assert data == expected


def test_mqtt_loader_prefetch(mock_broker: MockBroker) -> None:
def test_mqtt_loader_prefetch(mock_broker: MockBroker, mock_paho: MagicMock) -> None:
from dissect.target.loaders.mqtt import MQTTConnection

connection = MQTTConnection(mock_broker, "")
connection.prefetch_factor_inc = 10
assert connection.factor == 1
Expand Down Expand Up @@ -155,7 +171,11 @@ def test_mqtt_loader_prefetch(mock_broker: MockBroker) -> None:
"invalid_case_empty",
],
)
def test_case(case_name, parse_result: str | pytest.RaisesContext[argparse.ArgumentTypeError]) -> None:
def test_case(
case_name, parse_result: str | pytest.RaisesContext[argparse.ArgumentTypeError], mock_paho: MagicMock
) -> None:
from dissect.target.loaders.mqtt import case

if isinstance(parse_result, str):
assert case(case_name) == parse_result
else:
Expand Down
Loading